Bluetooth: audio: capabilities: Remove callbacks #50537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariuszSkamra
added
area: Bluetooth
area: Bluetooth Host
MariuszSkamra
requested review from
Thalley,
Vudentz,
asbjornsabo,
jhedberg and
sjanc
as code owners
Thalley
requested changes
Sep 25, 2022
MariuszSkamra
force-pushed
the
caps_assert
branch
from
0b09279 to
a8826aa
Compare
MariuszSkamra
changed the title
MariuszSkamra
force-pushed
the
caps_assert
branch
from
a8826aa to
24df14c
Compare
Thalley
previously approved these changes
Sep 28, 2022
MariuszSkamra
force-pushed
the
caps_assert
branch
3 times, most recently
from
9cfb3c3 to
ea9bc92
Compare
Thalley
previously approved these changes
Sep 29, 2022
sjanc
reviewed
Sep 29, 2022
This removes the callbacks from capabilities. The callbacks are used for unicast server role only, while the capabilities are used for the broadcast sink role as well. Thus the callbacks can be removed as there is another bt_audio_unicast_server_cb API that is specific for unicast server role. Signed-off-by: Mariusz Skamra <[email protected]>
MariuszSkamra
force-pushed
the
caps_assert
branch
from
ea9bc92 to
7d81371
Compare
sjanc
approved these changes
Sep 29, 2022
Thalley
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the callbacks from capabilities. The callbacks are used for
unicast server role only, while the capabilities are used for the
broadcast sink role as well. Thus the callbacks can be removed as there
is another bt_audio_unicast_server_cb API that is specific for unicast
server role.
Signed-off-by: Mariusz Skamra [email protected]